Disable TopicViewer_TEST on Windows and macOS #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <[email protected]>
chapulina
added
tests
Merged
claireyywang
approved these changes
Aug 6, 2020
|
There are some warnings on ubuntu CI related to the original PR https://build.osrfoundation.org/job/ignition_gui-ci-pr_any-ubuntu_auto-amd64/577/gcc/new/ERROR/, not sure if that'll break the buildfarm though |
Sorry, I had missed this comment. I think those warnings are only showing up now because of the new Jenkins plugin. I'm addressing them in #101 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #75.
I thought we could wait for #76 to be merged forward to disable the test, but on Windows the compilation was broken.